fix(outbound): unify resolved cfg threading across send paths (#33987)

This commit is contained in:
Josh Avant
2026-03-04 00:20:44 -06:00
committed by GitHub
parent 4d183af0cf
commit 646817dd80
62 changed files with 1780 additions and 117 deletions

View File

@@ -0,0 +1,63 @@
import { describe, expect, it, vi } from "vitest";
import { signalPlugin } from "./channel.js";
describe("signal outbound cfg threading", () => {
it("threads provided cfg into sendText deps call", async () => {
const cfg = {
channels: {
signal: {
accounts: {
work: {
mediaMaxMb: 12,
},
},
mediaMaxMb: 5,
},
},
};
const sendSignal = vi.fn(async () => ({ messageId: "sig-1" }));
const result = await signalPlugin.outbound!.sendText!({
cfg,
to: "+15551230000",
text: "hello",
accountId: "work",
deps: { sendSignal },
});
expect(sendSignal).toHaveBeenCalledWith("+15551230000", "hello", {
cfg,
maxBytes: 12 * 1024 * 1024,
accountId: "work",
});
expect(result).toEqual({ channel: "signal", messageId: "sig-1" });
});
it("threads cfg + mediaUrl into sendMedia deps call", async () => {
const cfg = {
channels: {
signal: {
mediaMaxMb: 7,
},
},
};
const sendSignal = vi.fn(async () => ({ messageId: "sig-2" }));
const result = await signalPlugin.outbound!.sendMedia!({
cfg,
to: "+15559870000",
text: "photo",
mediaUrl: "https://example.com/a.jpg",
accountId: "default",
deps: { sendSignal },
});
expect(sendSignal).toHaveBeenCalledWith("+15559870000", "photo", {
cfg,
mediaUrl: "https://example.com/a.jpg",
maxBytes: 7 * 1024 * 1024,
accountId: "default",
});
expect(result).toEqual({ channel: "signal", messageId: "sig-2" });
});
});

View File

@@ -80,6 +80,7 @@ async function sendSignalOutbound(params: {
accountId: params.accountId,
});
return await send(params.to, params.text, {
cfg: params.cfg,
...(params.mediaUrl ? { mediaUrl: params.mediaUrl } : {}),
...(params.mediaLocalRoots?.length ? { mediaLocalRoots: params.mediaLocalRoots } : {}),
maxBytes,