6a705a37f2
* docs: add ACP persistent binding experiment plan * docs: align ACP persistent binding spec to channel-local config * docs: scope Telegram ACP bindings to forum topics only * docs: lock bound /new and /reset behavior to in-place ACP reset * ACP: add persistent discord/telegram conversation bindings * ACP: fix persistent binding reuse and discord thread parent context * docs: document channel-specific persistent ACP bindings * ACP: split persistent bindings and share conversation id helpers * ACP: defer configured binding init until preflight passes * ACP: fix discord thread parent fallback and explicit disable inheritance * ACP: keep bound /new and /reset in-place * ACP: honor configured bindings in native command flows * ACP: avoid configured fallback after runtime bind failure * docs: refine ACP bindings experiment config examples * acp: cut over to typed top-level persistent bindings * ACP bindings: harden reset recovery and native command auth * Docs: add ACP bound command auth proposal * Tests: normalize i18n registry zh-CN assertion encoding * ACP bindings: address review findings for reset and fallback routing * ACP reset: gate hooks on success and preserve /new arguments * ACP bindings: fix auth and binding-priority review findings * Telegram ACP: gate ensure on auth and accepted messages * ACP bindings: fix session-key precedence and unavailable handling * ACP reset/native commands: honor fallback targets and abort on bootstrap failure * Config schema: validate ACP binding channel and Telegram topic IDs * Discord ACP: apply configured DM bindings to native commands * ACP reset tails: dispatch through ACP after command handling * ACP tails/native reset auth: fix target dispatch and restore full auth * ACP reset detection: fallback to active ACP keys for DM contexts * Tests: type runTurn mock input in ACP dispatch test * ACP: dedup binding route bootstrap and reset target resolution * reply: align ACP reset hooks with bound session key * docs: replace personal discord ids with placeholders * fix: add changelog entry for ACP persistent bindings (#34873) (thanks @dutifulbob) --------- Co-authored-by: Onur <2453968+osolmaz@users.noreply.github.com>
112 lines
3.6 KiB
TypeScript
112 lines
3.6 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import type { OpenClawConfig } from "../../../config/config.js";
|
|
import { buildCommandTestParams } from "../commands-spawn.test-harness.js";
|
|
import {
|
|
isAcpCommandDiscordChannel,
|
|
resolveAcpCommandBindingContext,
|
|
resolveAcpCommandConversationId,
|
|
} from "./context.js";
|
|
|
|
const baseCfg = {
|
|
session: { mainKey: "main", scope: "per-sender" },
|
|
} satisfies OpenClawConfig;
|
|
|
|
describe("commands-acp context", () => {
|
|
it("resolves channel/account/thread context from originating fields", () => {
|
|
const params = buildCommandTestParams("/acp sessions", baseCfg, {
|
|
Provider: "discord",
|
|
Surface: "discord",
|
|
OriginatingChannel: "discord",
|
|
OriginatingTo: "channel:parent-1",
|
|
AccountId: "work",
|
|
MessageThreadId: "thread-42",
|
|
});
|
|
|
|
expect(resolveAcpCommandBindingContext(params)).toEqual({
|
|
channel: "discord",
|
|
accountId: "work",
|
|
threadId: "thread-42",
|
|
conversationId: "thread-42",
|
|
parentConversationId: "parent-1",
|
|
});
|
|
expect(isAcpCommandDiscordChannel(params)).toBe(true);
|
|
});
|
|
|
|
it("resolves discord thread parent from ParentSessionKey when targets point at the thread", () => {
|
|
const params = buildCommandTestParams("/acp sessions", baseCfg, {
|
|
Provider: "discord",
|
|
Surface: "discord",
|
|
OriginatingChannel: "discord",
|
|
OriginatingTo: "channel:thread-42",
|
|
AccountId: "work",
|
|
MessageThreadId: "thread-42",
|
|
ParentSessionKey: "agent:codex:discord:channel:parent-9",
|
|
});
|
|
|
|
expect(resolveAcpCommandBindingContext(params)).toEqual({
|
|
channel: "discord",
|
|
accountId: "work",
|
|
threadId: "thread-42",
|
|
conversationId: "thread-42",
|
|
parentConversationId: "parent-9",
|
|
});
|
|
});
|
|
|
|
it("resolves discord thread parent from native context when ParentSessionKey is absent", () => {
|
|
const params = buildCommandTestParams("/acp sessions", baseCfg, {
|
|
Provider: "discord",
|
|
Surface: "discord",
|
|
OriginatingChannel: "discord",
|
|
OriginatingTo: "channel:thread-42",
|
|
AccountId: "work",
|
|
MessageThreadId: "thread-42",
|
|
ThreadParentId: "parent-11",
|
|
});
|
|
|
|
expect(resolveAcpCommandBindingContext(params)).toEqual({
|
|
channel: "discord",
|
|
accountId: "work",
|
|
threadId: "thread-42",
|
|
conversationId: "thread-42",
|
|
parentConversationId: "parent-11",
|
|
});
|
|
});
|
|
|
|
it("falls back to default account and target-derived conversation id", () => {
|
|
const params = buildCommandTestParams("/acp status", baseCfg, {
|
|
Provider: "slack",
|
|
Surface: "slack",
|
|
OriginatingChannel: "slack",
|
|
To: "<#123456789>",
|
|
});
|
|
|
|
expect(resolveAcpCommandBindingContext(params)).toEqual({
|
|
channel: "slack",
|
|
accountId: "default",
|
|
threadId: undefined,
|
|
conversationId: "123456789",
|
|
});
|
|
expect(resolveAcpCommandConversationId(params)).toBe("123456789");
|
|
expect(isAcpCommandDiscordChannel(params)).toBe(false);
|
|
});
|
|
|
|
it("builds canonical telegram topic conversation ids from originating chat + thread", () => {
|
|
const params = buildCommandTestParams("/acp status", baseCfg, {
|
|
Provider: "telegram",
|
|
Surface: "telegram",
|
|
OriginatingChannel: "telegram",
|
|
OriginatingTo: "telegram:-1001234567890",
|
|
MessageThreadId: "42",
|
|
});
|
|
|
|
expect(resolveAcpCommandBindingContext(params)).toEqual({
|
|
channel: "telegram",
|
|
accountId: "default",
|
|
threadId: "42",
|
|
conversationId: "-1001234567890:topic:42",
|
|
parentConversationId: "-1001234567890",
|
|
});
|
|
expect(resolveAcpCommandConversationId(params)).toBe("-1001234567890:topic:42");
|
|
});
|
|
});
|