* docs: add ACP thread-bound agents plan doc * docs: expand ACP implementation specification * feat(acp): route ACP sessions through core dispatch and lifecycle cleanup * feat(acp): add /acp commands and Discord spawn gate * ACP: add acpx runtime plugin backend * fix(subagents): defer transient lifecycle errors before announce * Agents: harden ACP sessions_spawn and tighten spawn guidance * Agents: require explicit ACP target for runtime spawns * docs: expand ACP control-plane implementation plan * ACP: harden metadata seeding and spawn guidance * ACP: centralize runtime control-plane manager and fail-closed dispatch * ACP: harden runtime manager and unify spawn helpers * Commands: route ACP sessions through ACP runtime in agent command * ACP: require persisted metadata for runtime spawns * Sessions: preserve ACP metadata when updating entries * Plugins: harden ACP backend registry across loaders * ACPX: make availability probe compatible with adapters * E2E: add manual Discord ACP plain-language smoke script * ACPX: preserve streamed spacing across Discord delivery * Docs: add ACP Discord streaming strategy * ACP: harden Discord stream buffering for thread replies * ACP: reuse shared block reply pipeline for projector * ACP: unify streaming config and adopt coalesceIdleMs * Docs: add temporary ACP production hardening plan * Docs: trim temporary ACP hardening plan goals * Docs: gate ACP thread controls by backend capabilities * ACP: add capability-gated runtime controls and /acp operator commands * Docs: remove temporary ACP hardening plan * ACP: fix spawn target validation and close cache cleanup * ACP: harden runtime dispatch and recovery paths * ACP: split ACP command/runtime internals and centralize policy * ACP: harden runtime lifecycle, validation, and observability * ACP: surface runtime and backend session IDs in thread bindings * docs: add temp plan for binding-service migration * ACP: migrate thread binding flows to SessionBindingService * ACP: address review feedback and preserve prompt wording * ACPX plugin: pin runtime dependency and prefer bundled CLI * Discord: complete binding-service migration cleanup and restore ACP plan * Docs: add standalone ACP agents guide * ACP: route harness intents to thread-bound ACP sessions * ACP: fix spawn thread routing and queue-owner stall * ACP: harden startup reconciliation and command bypass handling * ACP: fix dispatch bypass type narrowing * ACP: align runtime metadata to agentSessionId * ACP: normalize session identifier handling and labels * ACP: mark thread banner session ids provisional until first reply * ACP: stabilize session identity mapping and startup reconciliation * ACP: add resolved session-id notices and cwd in thread intros * Discord: prefix thread meta notices consistently * Discord: unify ACP/thread meta notices with gear prefix * Discord: split thread persona naming from meta formatting * Extensions: bump acpx plugin dependency to 0.1.9 * Agents: gate ACP prompt guidance behind acp.enabled * Docs: remove temp experiment plan docs * Docs: scope streaming plan to holy grail refactor * Docs: refactor ACP agents guide for human-first flow * Docs/Skill: add ACP feature-flag guidance and direct acpx telephone-game flow * Docs/Skill: add OpenCode and Pi to ACP harness lists * Docs/Skill: align ACP harness list with current acpx registry * Dev/Test: move ACP plain-language smoke script and mark as keep * Docs/Skill: reorder ACP harness lists with Pi first * ACP: split control-plane manager into core/types/utils modules * Docs: refresh ACP thread-bound agents plan * ACP: extract dispatch lane and split manager domains * ACP: centralize binding context and remove reverse deps * Infra: unify system message formatting * ACP: centralize error boundaries and session id rendering * ACP: enforce init concurrency cap and strict meta clear * Tests: fix ACP dispatch binding mock typing * Tests: fix Discord thread-binding mock drift and ACP request id * ACP: gate slash bypass and persist cleared overrides * ACPX: await pre-abort cancel before runTurn return * Extension: pin acpx runtime dependency to 0.1.11 * Docs: add pinned acpx install strategy for ACP extension * Extensions/acpx: enforce strict local pinned startup * Extensions/acpx: tighten acp-router install guidance * ACPX: retry runtime test temp-dir cleanup * Extensions/acpx: require proactive ACPX repair for thread spawns * Extensions/acpx: require restart offer after acpx reinstall * extensions/acpx: remove workspace protocol devDependency * extensions/acpx: bump pinned acpx to 0.1.13 * extensions/acpx: sync lockfile after dependency bump * ACPX: make runtime spawn Windows-safe * fix: align doctor-config-flow repair tests with default-account migration (#23580) (thanks @osolmaz)
132 lines
4.0 KiB
TypeScript
132 lines
4.0 KiB
TypeScript
import type { SessionAcpIdentity, SessionAcpMeta } from "../../config/sessions/types.js";
|
|
import { isSessionIdentityPending, resolveSessionIdentityFromMeta } from "./session-identity.js";
|
|
|
|
export const ACP_SESSION_IDENTITY_RENDERER_VERSION = "v1";
|
|
export type AcpSessionIdentifierRenderMode = "status" | "thread";
|
|
|
|
type SessionResumeHintResolver = (params: { agentSessionId: string }) => string;
|
|
|
|
const ACP_AGENT_RESUME_HINT_BY_KEY = new Map<string, SessionResumeHintResolver>([
|
|
[
|
|
"codex",
|
|
({ agentSessionId }) =>
|
|
`resume in Codex CLI: \`codex resume ${agentSessionId}\` (continues this conversation).`,
|
|
],
|
|
[
|
|
"openai-codex",
|
|
({ agentSessionId }) =>
|
|
`resume in Codex CLI: \`codex resume ${agentSessionId}\` (continues this conversation).`,
|
|
],
|
|
[
|
|
"codex-cli",
|
|
({ agentSessionId }) =>
|
|
`resume in Codex CLI: \`codex resume ${agentSessionId}\` (continues this conversation).`,
|
|
],
|
|
]);
|
|
|
|
function normalizeText(value: unknown): string | undefined {
|
|
if (typeof value !== "string") {
|
|
return undefined;
|
|
}
|
|
const trimmed = value.trim();
|
|
return trimmed || undefined;
|
|
}
|
|
|
|
function normalizeAgentHintKey(value: unknown): string | undefined {
|
|
const normalized = normalizeText(value);
|
|
if (!normalized) {
|
|
return undefined;
|
|
}
|
|
return normalized.toLowerCase().replace(/[\s_]+/g, "-");
|
|
}
|
|
|
|
function resolveAcpAgentResumeHintLine(params: {
|
|
agentId?: string;
|
|
agentSessionId?: string;
|
|
}): string | undefined {
|
|
const agentSessionId = normalizeText(params.agentSessionId);
|
|
const agentKey = normalizeAgentHintKey(params.agentId);
|
|
if (!agentSessionId || !agentKey) {
|
|
return undefined;
|
|
}
|
|
const resolver = ACP_AGENT_RESUME_HINT_BY_KEY.get(agentKey);
|
|
return resolver ? resolver({ agentSessionId }) : undefined;
|
|
}
|
|
|
|
export function resolveAcpSessionIdentifierLines(params: {
|
|
sessionKey: string;
|
|
meta?: SessionAcpMeta;
|
|
}): string[] {
|
|
const backend = normalizeText(params.meta?.backend) ?? "backend";
|
|
const identity = resolveSessionIdentityFromMeta(params.meta);
|
|
return resolveAcpSessionIdentifierLinesFromIdentity({
|
|
backend,
|
|
identity,
|
|
mode: "status",
|
|
});
|
|
}
|
|
|
|
export function resolveAcpSessionIdentifierLinesFromIdentity(params: {
|
|
backend: string;
|
|
identity?: SessionAcpIdentity;
|
|
mode?: AcpSessionIdentifierRenderMode;
|
|
}): string[] {
|
|
const backend = normalizeText(params.backend) ?? "backend";
|
|
const mode = params.mode ?? "status";
|
|
const identity = params.identity;
|
|
const agentSessionId = normalizeText(identity?.agentSessionId);
|
|
const acpxSessionId = normalizeText(identity?.acpxSessionId);
|
|
const acpxRecordId = normalizeText(identity?.acpxRecordId);
|
|
const hasIdentifier = Boolean(agentSessionId || acpxSessionId || acpxRecordId);
|
|
if (isSessionIdentityPending(identity) && hasIdentifier) {
|
|
if (mode === "status") {
|
|
return ["session ids: pending (available after the first reply)"];
|
|
}
|
|
return [];
|
|
}
|
|
const lines: string[] = [];
|
|
if (agentSessionId) {
|
|
lines.push(`agent session id: ${agentSessionId}`);
|
|
}
|
|
if (acpxSessionId) {
|
|
lines.push(`${backend} session id: ${acpxSessionId}`);
|
|
}
|
|
if (acpxRecordId) {
|
|
lines.push(`${backend} record id: ${acpxRecordId}`);
|
|
}
|
|
return lines;
|
|
}
|
|
|
|
export function resolveAcpSessionCwd(meta?: SessionAcpMeta): string | undefined {
|
|
const runtimeCwd = normalizeText(meta?.runtimeOptions?.cwd);
|
|
if (runtimeCwd) {
|
|
return runtimeCwd;
|
|
}
|
|
return normalizeText(meta?.cwd);
|
|
}
|
|
|
|
export function resolveAcpThreadSessionDetailLines(params: {
|
|
sessionKey: string;
|
|
meta?: SessionAcpMeta;
|
|
}): string[] {
|
|
const meta = params.meta;
|
|
const identity = resolveSessionIdentityFromMeta(meta);
|
|
const backend = normalizeText(meta?.backend) ?? "backend";
|
|
const lines = resolveAcpSessionIdentifierLinesFromIdentity({
|
|
backend,
|
|
identity,
|
|
mode: "thread",
|
|
});
|
|
if (lines.length === 0) {
|
|
return lines;
|
|
}
|
|
const hint = resolveAcpAgentResumeHintLine({
|
|
agentId: meta?.agent,
|
|
agentSessionId: identity?.agentSessionId,
|
|
});
|
|
if (hint) {
|
|
lines.push(hint);
|
|
}
|
|
return lines;
|
|
}
|