negodiy/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Tests: extend exec allowlist glob coverage

Browse Source
This commit is contained in:
Vincent Koc
2026-03-12 04:01:49 -04:00
parent 9aeaa19e9e
commit 97683071b5
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/infra/exec-allowlist-pattern.test.ts
View File

@@ -7,8 +7,18 @@ describe("matchesExecAllowlistPattern", () => {
expect(matchesExecAllowlistPattern("/tmp/a?b", "/tmp/acb")).toBe(true);
});
it("keeps ** matching across path separators", () => {
expect(matchesExecAllowlistPattern("/tmp/**/tool", "/tmp/a/b/tool")).toBe(true);
});
it.runIf(process.platform !== "win32")("preserves case sensitivity on POSIX", () => {
expect(matchesExecAllowlistPattern("/tmp/Allowed-Tool", "/tmp/allowed-tool")).toBe(false);
expect(matchesExecAllowlistPattern("/tmp/Allowed-Tool", "/tmp/Allowed-Tool")).toBe(true);
});
it.runIf(process.platform === "win32")("preserves case-insensitive matching on Windows", () => {
expect(matchesExecAllowlistPattern("C:/Tools/Allowed-Tool", "c:/tools/allowed-tool")).toBe(
true,
);
});
});

5
src/infra/exec-allowlist-pattern.ts
View File

@@ -25,7 +25,8 @@ function escapeRegExpLiteral(input: string): string {
}
function compileGlobRegex(pattern: string): RegExp {
const cached = globRegexCache.get(pattern);
const cacheKey = `${process.platform}:${pattern}`;
const cached = globRegexCache.get(cacheKey);
if (cached) {
return cached;
}
@@ -59,7 +60,7 @@ function compileGlobRegex(pattern: string): RegExp {
if (globRegexCache.size >= GLOB_REGEX_CACHE_LIMIT) {
globRegexCache.clear();
}
globRegexCache.set(pattern, compiled);
globRegexCache.set(cacheKey, compiled);
return compiled;
}